Refactor ExportPlaylist to use more idiomatic kotlin code#12981
Merged
theimpulson merged 1 commit intoTeamNewPipe:devfrom Jan 1, 2026
Merged
Refactor ExportPlaylist to use more idiomatic kotlin code#12981theimpulson merged 1 commit intoTeamNewPipe:devfrom
theimpulson merged 1 commit intoTeamNewPipe:devfrom
Conversation
theimpulson
reviewed
Jan 1, 2026
app/src/main/java/org/schabi/newpipe/local/playlist/ExportPlaylist.kt
Outdated
Show resolved
Hide resolved
dustdfg
force-pushed
the
export_playlist_refactor
branch
from
edacd69 to
49378d4
Compare
theimpulson
requested changes
Jan 1, 2026
Member
theimpulson
left a comment
theimpulson
left a comment
There was a problem hiding this comment.
Looks good to me other than a minor nitpick
app/src/main/java/org/schabi/newpipe/local/playlist/PlayListShareMode.kt
Outdated
Show resolved
Hide resolved
dustdfg
force-pushed
the
export_playlist_refactor
branch
from
49378d4 to
8379aa0
Compare
github-actions
bot
added
size/small
theimpulson
approved these changes
Jan 1, 2026
ShareASmile
added
the
codequality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence