Skip to content

Replace findPreference(getString(resId) with its null safe shortcut#12973

Merged
theimpulson merged 1 commit intoTeamNewPipe:devfrom
dustdfg:require_preference
Jan 1, 2026
Merged

Replace findPreference(getString(resId) with its null safe shortcut#12973
theimpulson merged 1 commit intoTeamNewPipe:devfrom
dustdfg:require_preference

Conversation

@dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Dec 30, 2025

What is it?

  • Codebase improvement (dev facing)

Description of the changes in your PR

  • Replace findPreference(getString(resId) with its null safe shortcut requirePreference(resid)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/medium PRs with less than 250 changed lines label Dec 30, 2025
@TobiGr TobiGr added the codequality Improvements to the codebase to improve the code quality label Dec 30, 2025
Copy link
Member

@theimpulson theimpulson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@theimpulson theimpulson merged commit 93166af into TeamNewPipe:dev Jan 1, 2026
6 checks passed
@dustdfg dustdfg deleted the require_preference branch January 7, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codequality Improvements to the codebase to improve the code quality size/medium PRs with less than 250 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants