Skip to content

Use context.getString() shorthand instead of context.getResources().getString()#12949

Merged
TobiGr merged 1 commit intoTeamNewPipe:refactorfrom
dustdfg:unnecessary_get_resources
Dec 27, 2025
Merged

Use context.getString() shorthand instead of context.getResources().getString()#12949
TobiGr merged 1 commit intoTeamNewPipe:refactorfrom
dustdfg:unnecessary_get_resources

Conversation

@dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Dec 26, 2025

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Use context.getString() shorthand instead of context.getResources().getString()

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Dec 26, 2025
Copy link
Member

@theimpulson theimpulson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@TobiGr TobiGr merged commit 8b038ef into TeamNewPipe:refactor Dec 27, 2025
9 of 10 checks passed
@dustdfg dustdfg deleted the unnecessary_get_resources branch December 27, 2025 18:23
TobiGr pushed a commit that referenced this pull request Dec 27, 2025
@TobiGr
Copy link
Contributor

TobiGr commented Dec 27, 2025

Backported to dev in c2f526d

@TobiGr TobiGr mentioned this pull request Dec 27, 2025
4 tasks
@ShareASmile ShareASmile added the codequality Improvements to the codebase to improve the code quality label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codequality Improvements to the codebase to improve the code quality size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants