Skip to content

Fix insufficient permissions on opening downloaded streams#12934

Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom
TobiGr:fix/open-download
Dec 23, 2025
Merged

Fix insufficient permissions on opening downloaded streams#12934
TobiGr merged 1 commit intoTeamNewPipe:devfrom
TobiGr:fix/open-download

Conversation

@TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Dec 22, 2025

What is it?

  • Bugfix (user facing)

Description of the changes in your PR

This fixes a crash which occours while trying to play a downloaded stream from within the Downloads view. The crash is caused by insufficient permissions because the permissions are not correctly passed to the app the file is shared with.

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@TobiGr TobiGr added the bug Issue is related to a bug label Dec 22, 2025
@TobiGr TobiGr added this to v0.28.x Dec 22, 2025
@TobiGr TobiGr added the downloader Issue is related to the downloader label Dec 22, 2025
@github-project-automation github-project-automation bot moved this to Todo in v0.28.x Dec 22, 2025
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Dec 22, 2025
@TobiGr TobiGr marked this pull request as ready for review December 22, 2025 15:23
@TobiGr TobiGr merged commit 2ee5f99 into TeamNewPipe:dev Dec 23, 2025
9 of 10 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in v0.28.x Dec 23, 2025
@TobiGr TobiGr deleted the fix/open-download branch December 23, 2025 08:35
@TobiGr TobiGr mentioned this pull request Dec 27, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug downloader Issue is related to the downloader size/small PRs with less than 50 changed lines

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Crash while trying to open a downloaded video

2 participants