Player: Enqueue next on the existing playQueue

[theimpulson]

What is it?

• Bugfix (user facing)
• Feature (user facing) ⚠️ Your PR must target the refactor branch
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Fixes "Enqueue next" after 150649a

Fixes the following issue(s)

• Fixes [Regression] Enqueue next doesn't work #12882

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.

[theimpulson]

I am unsure if this is the expected behavior of enqueue next but this adds the item to the existing queue but as the 3rd index if we are currently playing at 1st. I would expect enqueue next to add the items at 2nd index. is 3rd the expected behavior?

[theimpulson]

I am unsure if this is the expected behavior of enqueue next but this adds the item to the existing queue but as the 3rd index if we are currently playing at 1st. I would expect enqueue next to add the items at 2nd index. is 3rd the expected behavior?

Nevermind, seems the UI is not properly updated to reflect the change. Seems like a different bug. Workaround is enqueuing an item which forces to update the UI properly.

[TobiGr]

I also noticed that, the interesting thing is that it only happens with the background player for me:

Video Player	Background Player
Video Player.webm

Notice that the items are swapped when opening the fragment. Maybe something is not cleared correctly.

Should we open a new issue for that?

Edit:

In PlayQueueAdapter, onNext() is called again when opening the View.

[Stypox]

Should we open a new issue for that?

I think this has been a longstanding issue, see #9669 (but it happened before we had enqueue-next, too)