Always do not rotate screen when Android TV#12840
Conversation
TobiGr
added
bug
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
thank you. Can be merged once my comment is addressed.
| // In tablet user experience will be better if screen will not be rotated | ||
| // from landscape to portrait every time. | ||
| // Just turn on fullscreen mode in landscape orientation | ||
| // or portrait & unlocked global orientation | ||
| final boolean isLandscape = DeviceUtils.isLandscape(requireContext()); | ||
| if (DeviceUtils.isTablet(activity) | ||
| if (DeviceUtils.isTv(activity) || DeviceUtils.isTablet(activity) |
There was a problem hiding this comment.
Please add a comment regarding reasoning to check whether the device is a TV.
There was a problem hiding this comment.
Should I add comment in the code or leave comment here? I also need to update comments in the code, right?
There was a problem hiding this comment.
just add the reasoning to the comments above which explain the other conditions.
There was a problem hiding this comment.
Thanks, I've add comment, please review again,
// On Android TV screen rotation is not supported
scola
force-pushed
the
rotate_on_androidtv_issue
branch
from
770b8b1 to
e045251
Compare
TobiGr
added
the
player
|
Could you test #12781 and check whether this also solves the problem for you? That PR has a more general approach to fix related bugs with tablets. |
I just tested the apk for check/CI of 12781, It also solved my issues on my android TV. Thanks |
2 participants
What is it?
refactorbranchDescription of the changes in your PR
Before/After Screenshots/Screen Record
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
I have tested my change by local build, it works
Due diligence