Skip to content

Add enqueue option to router dialog#12821

Merged
TobiGr merged 2 commits intoTeamNewPipe:refactorfrom
HatakeKakashri:add_to_queue_menu_option
Dec 20, 2025
Merged

Add enqueue option to router dialog#12821
TobiGr merged 2 commits intoTeamNewPipe:refactorfrom
HatakeKakashri:add_to_queue_menu_option

Conversation

@HatakeKakashri
Copy link
Contributor

@HatakeKakashri HatakeKakashri commented Nov 19, 2025

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • This allows users to enqueue a stream directly to the current player queue when sharing a link with the app, improving the user experience for queue management.
  • The 'Enqueue' option is now available in the action selection dialog and can also be set as the preferred open action in the settings.

Before/After Screenshots/Screen Record

Screen_recording_20251120_202152.mp4

Fixes the following issue(s)

Relies on the following changes

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Nov 19, 2025
@absurdlylongusername
Copy link
Member

Please add screenshots/recordings to demonstrate the functionality that this PR adds, and reference the issue that this PR fixes

@HatakeKakashri
Copy link
Contributor Author

Please add screenshots/recordings to demonstrate the functionality that this PR adds, and reference the issue that this PR fixes

This is done

@github-actions github-actions bot added size/medium PRs with less than 250 changed lines and removed size/small PRs with less than 50 changed lines labels Dec 14, 2025
@TobiGr
Copy link
Contributor

TobiGr commented Dec 14, 2025

Hello and thank you for the PR. I added a commit to check that there is a queue to which the user can enqueue items. I also made the enqueue option available when sharing playlists to NewPipe. I also moved the option up so enqueue is positioned right after the other player options.

The commit history of your branch is a little strange.

Details

grafik

I wanted to do a quick rebase but that's not possible without resolving a bunch of conflicts. Please cherry pick the two commits, fix the conflicts, undo the changes in libs.version.toml and force push. After that this is good to go.

@TobiGr TobiGr added the feature request Issue is related to a feature in the app label Dec 14, 2025
@TobiGr TobiGr added this to v0.28.x Dec 14, 2025
@github-project-automation github-project-automation bot moved this to Todo in v0.28.x Dec 14, 2025
HatakeKakashri and others added 2 commits December 20, 2025 20:31
- This allows users to enqueue a stream directly to the current player queue when sharing a link with the app, improving the user experience for queue management.
- The 'Enqueue' option is now available in the action selection dialog and can also be set as the preferred open action in the settings.
Make enqueue option avilable for playlists as well
@TobiGr TobiGr force-pushed the add_to_queue_menu_option branch from ab1e0b2 to c596476 Compare December 20, 2025 19:31
@github-actions github-actions bot added size/small PRs with less than 50 changed lines and removed size/medium PRs with less than 250 changed lines labels Dec 20, 2025
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, i rebased

@TobiGr TobiGr merged commit 8e32e7a into TeamNewPipe:refactor Dec 20, 2025
8 of 9 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in v0.28.x Dec 20, 2025
@TobiGr
Copy link
Contributor

TobiGr commented Dec 20, 2025

this simple change was ported back to dev (acaaec2, 5582eac)

@TobiGr TobiGr mentioned this pull request Dec 21, 2025
4 tasks
@HatakeKakashri
Copy link
Contributor Author

HatakeKakashri commented Dec 22, 2025

Hello and thank you for the PR. I added a commit to check that there is a queue to which the user can enqueue items. I also made the enqueue option available when sharing playlists to NewPipe. I also moved the option up so enqueue is positioned right after the other player options.

The commit history of your branch is a little strange.

Details

grafik

I wanted to do a quick rebase but that's not possible without resolving a bunch of conflicts. Please cherry pick the two commits, fix the conflicts, undo the changes in libs.version.toml and force push. After that this is good to go.

Somehow I missed this comment. My bad.

Actually in my testing I have seen one bug. Start playing an item in the app -> click on external link, select enquque option in the menu -> open the app, very that external item is now added -> within the app long press on another item and try "enqueue" and "enqueue next" option. The "enque next" option did not add item to the list at all.

I see there have been a PR with "enqueue next" as well, so will test this workflow in 28.1 apk

Update: Tested on v28.1, not seeing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request Issue is related to a feature in the app size/small PRs with less than 50 changed lines

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants