Skip to content

[Build] Fix Extractor dependency substitution after settings.gradle conversion#12760

Closed
TobiGr wants to merge 1 commit intodevfrom
kts-fixes
Closed

[Build] Fix Extractor dependency substitution after settings.gradle conversion#12760
TobiGr wants to merge 1 commit intodevfrom
kts-fixes

Conversation

@TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Oct 31, 2025

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Convert commented out dependency substitution for NewPipe Extractor in settings.gradle.kts
Introduced by #12706

Fixes the following issue(s)

A Gradle sync issue complaining about wrong syntax

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Oct 31, 2025
@TobiGr
Copy link
Contributor Author

TobiGr commented Nov 2, 2025

#12765 also fixes this using identical measures but has a better PR description

@TobiGr TobiGr closed this Nov 2, 2025
@TobiGr TobiGr deleted the kts-fixes branch November 2, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant