Skip to content

Workaround popup player UI elements being pushed out / Set a maxWidth for audioTrackTextView #12729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stypox merged 1 commit into from
Oct 21, 2025
Merged

Workaround popup player UI elements being pushed out / Set a maxWidth for audioTrackTextView #12729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/src/main/java/org/schabi/newpipe/player/ui/MainPlayerUi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,9 @@ protected void setupElementsVisibility() {
binding.topControls.setFocusable(true);

binding.metadataView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE);

// Reset workaround changes from popup player
binding.audioTrackTextView.setMaxWidth(Integer.MAX_VALUE);
}

@Override
Expand Down
3 changes: 3 additions & 0 deletions app/src/main/java/org/schabi/newpipe/player/ui/PopupPlayerUi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import org.schabi.newpipe.player.gesture.BasePlayerGestureListener;
import org.schabi.newpipe.player.gesture.PopupPlayerGestureListener;
import org.schabi.newpipe.player.helper.PlayerHelper;
import org.schabi.newpipe.util.DeviceUtils;

public final class PopupPlayerUi extends VideoPlayerUi {
private static final String TAG = PopupPlayerUi.class.getSimpleName();
Expand Down Expand Up @@ -174,6 +175,8 @@ protected void setupElementsVisibility() {
binding.topControls.setClickable(false);
binding.topControls.setFocusable(false);
binding.bottomControls.bringToFront();
// Workaround that UI elements are pushed off screen
binding.audioTrackTextView.setMaxWidth(DeviceUtils.dpToPx(48, context));
super.setupElementsVisibility();
}

Expand Down