Skip to content

Add option to delete a download without also deleting file#12544

Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom
Stypox:download-options
Aug 27, 2025
Merged

Add option to delete a download without also deleting file#12544
TobiGr merged 1 commit intoTeamNewPipe:devfrom
Stypox:download-options

Conversation

@Stypox
Copy link
Member

@Stypox Stypox commented Aug 16, 2025

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Some user at FrOSCon reported that the "Delete" button in the Download screen was confusing because they expected it to only delete the entry instead of also deleting the file, so I made that clearer by changing the string from "Delete" to "Delete file" and also added a "Delete entry" button that just deletes the entry.

Before/After Screenshots/Screen Record

image

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/medium PRs with less than 250 changed lines label Aug 16, 2025
@HatakeKakashri
Copy link
Contributor

I tried this on my phone and realized that there is no confirmation before deleting the download/file. I understand that the user has already selected the 'Delete' option, but should we have a confirmation dialog to warn the user that the file is going to be deleted? Something like this:
image

@Stypox
Copy link
Member Author

Stypox commented Aug 19, 2025

@snaik20 there is a confirmation in the form of an "Undo" button in the snackbar. If you accidentally delete something, you can undo within one minute or so (before the snackbar disappears)

@HatakeKakashri
Copy link
Contributor

@snaik20 there is a confirmation in the form of an "Undo" button in the snackbar. If you accidentally delete something, you can undo within one minute or so (before the snackbar disappears)

You are right, the undo option is a good way to prevent accidental deletions.

My suggestion was for a similar purpose, but I’m happy to go with the existing approach with 'undo'.

@TobiGr TobiGr added the downloader Issue is related to the downloader label Aug 27, 2025
@TobiGr TobiGr merged commit ccd76de into TeamNewPipe:dev Aug 27, 2025
6 checks passed
@TobiGr TobiGr mentioned this pull request Dec 21, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

downloader Issue is related to the downloader size/medium PRs with less than 250 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants