Add option to delete a download without also deleting file#12544
Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom Aug 27, 2025
Merged
Add option to delete a download without also deleting file#12544TobiGr merged 1 commit intoTeamNewPipe:devfrom
TobiGr merged 1 commit intoTeamNewPipe:devfrom
Conversation
Contributor
Member
Author
|
@snaik20 there is a confirmation in the form of an "Undo" button in the snackbar. If you accidentally delete something, you can undo within one minute or so (before the snackbar disappears) |
Contributor
You are right, the undo option is a good way to prevent accidental deletions. My suggestion was for a similar purpose, but I’m happy to go with the existing approach with 'undo'. |
HatakeKakashri
approved these changes
Aug 19, 2025
TobiGr
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What is it?
Description of the changes in your PR
Some user at FrOSCon reported that the "Delete" button in the Download screen was confusing because they expected it to only delete the entry instead of also deleting the file, so I made that clearer by changing the string from "Delete" to "Delete file" and also added a "Delete entry" button that just deletes the entry.
Before/After Screenshots/Screen Record
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence