Revert Android 13+ per-app language preferences#12478
Closed
Stypox wants to merge 1 commit intoTeamNewPipe:release-0.28.0from
Closed
Revert Android 13+ per-app language preferences#12478Stypox wants to merge 1 commit intoTeamNewPipe:release-0.28.0from
Stypox wants to merge 1 commit intoTeamNewPipe:release-0.28.0from
Conversation
Stypox
added
bug
litetex
requested changes
Jul 29, 2025
Member
There was a problem hiding this comment.
It seems like it's possible to manually add supported languages to the native Android language picker: https://developer.android.com/guide/topics/resources/app-languages#use-localeconfig
Update: Never mind, that method was tried by @Stypox and was unsuccessful.
5 tasks
Member
Author
|
Closing, see #12093 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
See here for why this is needed. At least we can keep the code that changes the language on the fly though, without requiring an app restart. @Isira-Seneviratne could you confirm that this removes support for per-app languages correctly?
I tested on API 30, 31, 34, 36 and the language switch worked on all of them. Latin also works.
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence