Skip to content

Fix short count formatting for Android versions below 7.0#12460

Merged
TobiGr merged 2 commits intoTeamNewPipe:devfrom
Isira-Seneviratne:Short-count-refactor
Aug 1, 2025
Merged

Fix short count formatting for Android versions below 7.0#12460
TobiGr merged 2 commits intoTeamNewPipe:devfrom
Isira-Seneviratne:Short-count-refactor

Conversation

@Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Jul 24, 2025

What is it?

  • Bugfix (user facing)

Description of the changes in your PR

  • Fix the short count formatting method so that it returns strings similar to that on Android 7.0 and later.
  • Avoid using string concatenation in the same method, as it would cause layout issues on RTL languages.

Before/After Screenshots/Screen Record

Before After
Before After

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/large PRs with less than 750 changed lines label Jul 24, 2025
@TobiGr TobiGr added localisation / translation Everything that has to do with translations or Weblate bug Issue is related to a bug labels Jul 24, 2025
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this should merged into dev after 0.28.0 is released to avoid Weblate conflicts. We need to pull the changelog and migration info translations from weblate and should not include this in the next release to allow the translators to translate the new strings.

@TobiGr TobiGr added this to v0.28.x Jul 24, 2025
@github-project-automation github-project-automation bot moved this to Todo in v0.28.x Jul 24, 2025
@TobiGr TobiGr moved this from Todo to In Progress in v0.28.x Jul 24, 2025
@TobiGr TobiGr merged commit ff3526b into TeamNewPipe:dev Aug 1, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in v0.28.x Aug 1, 2025
@Isira-Seneviratne Isira-Seneviratne deleted the Short-count-refactor branch August 1, 2025 22:31
@TobiGr TobiGr mentioned this pull request Dec 21, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug localisation / translation Everything that has to do with translations or Weblate size/large PRs with less than 750 changed lines

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants