Skip to content

Fix new badge links on Readme being rendered incorrectly#12434

Merged
Stypox merged 2 commits intodevfrom
fix-new-badge-links-on-readme
Jul 19, 2025
Merged

Fix new badge links on Readme being rendered incorrectly#12434
Stypox merged 2 commits intodevfrom
fix-new-badge-links-on-readme

Conversation

@litetex
Copy link
Copy Markdown
Member

@litetex litetex commented Jul 16, 2025

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Currently there is an invisible white-space that is rendered as a link:

grafik

This PR fixes this by keeping the same format as the other links.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Jul 16, 2025
@AudricV AudricV added the meta Related to the project but not strictly to code label Jul 16, 2025
Copy link
Copy Markdown
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be done in all translated readmes too, right?

@github-actions github-actions bot added size/medium PRs with less than 250 changed lines and removed size/small PRs with less than 50 changed lines labels Jul 17, 2025
@litetex
Copy link
Copy Markdown
Member Author

litetex commented Jul 17, 2025

@Stypox Fixed

@litetex
Copy link
Copy Markdown
Member Author

litetex commented Jul 17, 2025

Please note that I can't merge this because some jobs are marked as required and are not executed because there is nothing to execute.

Maybe we should remove the requirement?

@litetex litetex requested a review from Stypox July 17, 2025 17:43
@HatakeKakashri HatakeKakashri force-pushed the fix-new-badge-links-on-readme branch from 8e0b6fc to f64dba0 Compare July 19, 2025 17:14
@Stypox Stypox merged commit e61f98b into dev Jul 19, 2025
1 check passed
@TobiGr TobiGr deleted the fix-new-badge-links-on-readme branch July 19, 2025 19:04
@litetex litetex mentioned this pull request Oct 15, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Related to the project but not strictly to code size/medium PRs with less than 250 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants