Fix fullscreen eliciting "clear queue" prompt#12416
Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom Jul 7, 2025
Merged
Conversation
This was referenced Jul 7, 2025
7 tasks
TobiGr
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixes #12297 by avoiding to pass
playAfterConnect=trueafter toggling fullscreen, which triggered the code to open the player and thus asked to replace the queue.Fixes #12296 by again avoiding to pass
playAfterConnect=trueright after switching out of fullscreen, which again triggered the code to open the player and due to "Start main player in fullscreen" being set totruemade it so that theVideoDetailFragmentwent back to fullscreen again.This PR makes it so that
playAfterConnectdoes not persist, and instead is reset tofalseafteronPlayerConnectedis used. Keeping it totrueused to not cause issues before #12044, but commit a7a7dc5 added more calls toonPlayerConnectedto ensure the video detail fragment remains in sync with the current player. The whole logic aroundplayAfterConnectis very bad, but hopefully this change does not create any problem, since there is no place whereplayAfterConnectis read other thanonPlayerConnected.APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence