Skip to content

Fix fullscreen eliciting "clear queue" prompt#12416

Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom
Stypox:fix-fullscreen-clear-queue-prompt
Jul 7, 2025
Merged

Fix fullscreen eliciting "clear queue" prompt#12416
TobiGr merged 1 commit intoTeamNewPipe:devfrom
Stypox:fix-fullscreen-clear-queue-prompt

Conversation

@Stypox
Copy link
Member

@Stypox Stypox commented Jul 7, 2025

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Fixes #12297 by avoiding to pass playAfterConnect=true after toggling fullscreen, which triggered the code to open the player and thus asked to replace the queue.

Fixes #12296 by again avoiding to pass playAfterConnect=true right after switching out of fullscreen, which again triggered the code to open the player and due to "Start main player in fullscreen" being set to true made it so that the VideoDetailFragment went back to fullscreen again.

This PR makes it so that playAfterConnect does not persist, and instead is reset to false after onPlayerConnected is used. Keeping it to true used to not cause issues before #12044, but commit a7a7dc5 added more calls to onPlayerConnected to ensure the video detail fragment remains in sync with the current player. The whole logic around playAfterConnect is very bad, but hopefully this change does not create any problem, since there is no place where playAfterConnect is read other than onPlayerConnected.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@Stypox Stypox added this to v0.28.x Jul 7, 2025
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Jul 7, 2025
@Stypox Stypox moved this to In Progress in v0.28.x Jul 7, 2025
@Stypox Stypox added bug Issue is related to a bug ASAP Issue needs to be fixed as soon as possible player Issues related to any player (main, popup and background) labels Jul 7, 2025
@TobiGr TobiGr merged commit c9559fa into TeamNewPipe:dev Jul 7, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in v0.28.x Jul 7, 2025
@Stypox Stypox deleted the fix-fullscreen-clear-queue-prompt branch July 16, 2025 13:53
@Stypox Stypox mentioned this pull request Jul 17, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ASAP Issue needs to be fixed as soon as possible bug Issue is related to a bug player Issues related to any player (main, popup and background) size/small PRs with less than 50 changed lines

Projects

Status: Done

2 participants