Fix stream notification grouping

[Isira-Seneviratne]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• It is possible for the stream uploader URL to be different from the channel URL, thus resulting in the notifications not being grouped by the channel. This change fixes that.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Stypox]

Thanks! Seems fine, though I didn't test. Can you provide a database I could import where this happens? Also, can you point to any open issue related to this? Also, please remove the parts of the template you don't use, when you open a PR.

[Isira-Seneviratne]

Here's an example database: newpipe_subscriptions_202502280744.json

There isn't an open issue related to this I could find, it's just an issue I came across while running the app. I dug deeper and found that the stream uploader URL is different from the channel URL, so the notifications aren't properly grouped.

[Stypox]

Mmmh, I still get a lot of distinct notifications, and there does not seem to be a difference between what I get with this PR and what I get before this PR.

Initial (**all** notifications are from TTaTST)	After unsubscribing from TTaTST

I tested this code by deleting all feed data manually by putting this code somewhere:

        new Thread(
                () -> {
                    NewPipeDatabase.getInstance(requireContext()).feedDAO().deleteAll();
                    NewPipeDatabase.getInstance(requireContext()).feedGroupDAO().deleteAll();
                    NewPipeDatabase.getInstance(requireContext()).streamDAO().deleteAll();
                }
        ).start();

[Stypox]

I tried logging all of the channel URLs being used for setGroup and they seem correct so it's just Android deciding not to group them for some reason, sorry for the wrong review. I don't understand how Android groups notifications, because I get a mess of notifications grouped badly, but oh well...

[Isira-Seneviratne]

I tried logging all of the channel URLs being used for setGroup and they seem correct so it's just Android deciding not to group them for some reason, sorry for the wrong review. I don't understand how Android groups notifications, because I get a mess of notifications grouped badly, but oh well...

https://developer.android.com/develop/ui/views/notifications/group

[Stypox]

Automatic grouping behavior might vary on some device types. To provide the best experience on all devices and versions, if you know notifications must be grouped, specify a group key and group summary to make sure they are grouped.

So maybe we need to specify one notification to be the group summary for each channel?

[Isira-Seneviratne]

So maybe we need to specify one notification to be the group summary for each channel?

That's already being done in line 60, the issue was that the group key was different for the summary notification and the other notifications.

[Stypox]

I still wonder why they were not grouping well when I tested it (there were like 100s of ungrouped notifications from the same channel), but the code looks indeed correct