Fix related items list enqueue popup crash#11614
Merged
TobiGr merged 5 commits intoTeamNewPipe:devfrom Nov 3, 2024
Merged
Conversation
…-change Fix Crash on Related Items Modal
ShareASmile
added
bug
6 tasks
TobiGr
reviewed
Nov 2, 2024
Contributor
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
Thank you for the PR!
The code looks good and is well documented 👍
I have a small suggestions which is more about readability and maintainability.
app/src/main/java/org/schabi/newpipe/fragments/list/videos/RelatedItemsFragment.java
Show resolved
Hide resolved
…atedItemsFragment.java Co-authored-by: Tobi <[email protected]>
|
TobiGr
approved these changes
Nov 3, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
InfoItemDialogpopup modal for theRelatedItemsFragmentto be attached to the parent context of theRelatedItemsFragment. This prevents the popup from not being attached a context when the player automatically changes to the next video and theRelatedItemsFragmentis re-initialized.Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence