Fix GitHub workflow for Android tests#11014
Merged
HatakeKakashri merged 1 commit intoTeamNewPipe:devfrom Apr 28, 2024
Merged
Conversation
- The github workflow fails when running android tests. - The workflow is trying to launch an x86 emulator on aarch-64 (macos-latest) host. - The macos-latest system seem to be used originally as it supports hardware acceleration. - This is no longer recomended, and ubuntu-latest host can handle the same and be faster than macos-latest. Doc: https://github.com/marketplace/actions/android-emulator-runner#running-hardware-accelerated-emulators-on-linux-runners
|
6 tasks
Contributor
Author
|
@XiangRongLin requested review from you as Github suggested and given previous change was yours. |
wb9688
approved these changes
Apr 28, 2024
Member
wb9688
left a comment
wb9688
left a comment
There was a problem hiding this comment.
LGTM, though maybe we can add AVD caching as well, but that's not really important
Contributor
Author
Thanks, that sounds like a great idea to reduce startup time. I think we can try that out separately. Merging this PR to unblock failing workflow. |
AudricV
changed the title
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Doc: https://github.com/marketplace/actions/android-emulator-runner#running-hardware-accelerated-emulators-on-linux-runners
Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence