Skip to content

Add Android Per App Language Support#10994

Closed
ghost wants to merge 1 commit intodevfrom
unknown repository
Closed

Add Android Per App Language Support#10994
ghost wants to merge 1 commit intodevfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 24, 2024

What is it?

  • Feature (user facing)

Description of the changes in your PR

Feature added by Android 13 to support "natively" app languages.

https://developer.android.com/guide/topics/resources/app-languages

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Apr 24, 2024
@TobiGr TobiGr added the localisation / translation Everything that has to do with translations or Weblate label Apr 24, 2024
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@HatakeKakashri HatakeKakashri added the template ignored The user didn't follow the template/instructions (or removed them) label Apr 24, 2024
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 24, 2024

@ghost
Copy link
Copy Markdown
Author

ghost commented May 16, 2024

Any news for this PR ?

Copy link
Copy Markdown
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and sorry for the late reply.
NewPipe has an in-app language chooser (settings > content > app language). This one conflicts with the language chosen in the Android app settings when a language is set. The language chosen inside the app is used. Everything works fine when the "system default" option is chosen. Not sure if this is an unwanted behaviour in terms of accessibility.

PS: you might want to rebase to fix the CI

@Profpatsch
Copy link
Copy Markdown
Contributor

Hi @Arthur-GYT, I’ll close this PR for now. If you ever come back to it, please open another one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

localisation / translation Everything that has to do with translations or Weblate size/small PRs with less than 50 changed lines template ignored The user didn't follow the template/instructions (or removed them)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants