Migrate to non-transitive R classes#10918
Merged
Stypox merged 1 commit intoTeamNewPipe:devfrom May 8, 2024
Merged
Conversation
5 tasks
Member
Isira-Seneviratne
left a comment
There was a problem hiding this comment.
Looks good to me overall, there's one small change I'd recommend making.
430f13c to
f4fb960
Compare
|
Member
Author
|
Merging, so that nightly testers can report bugs in case there is anything we missed. As explained in the PR description, I tested all changes and found no issue. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What is it?
Description of the changes in your PR
R.id.*did not exist anymore and had to be replaced by the fully-qualified path.R.id.content->android.R.id.contentto find the root view of an activity. I tested this manually and it works.R.attr.colorSecondary->android.R.attr.windowBackgroundas the bottom toolbar background color. I don't know why it wascolorSecondarybefore, butwindowBackgroundyields the same color as before, I tested on API 33 and API 22 on all themes. MoreoverwindowBackgroundis defined directly in styles.xml, so it should be correct.R.attr.colorAccent->android.R.attr.colorAccentas the bottom toolbar foreground color. Again, I tested on API 33 and API 22 on all themes and noticed no difference.R.attr.selectableItemBackground->android.R.attr.selectableItemBackgroundAPK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence