fix: ensure hold is unaffected by incline or pos control events#688
Open
Naptie wants to merge 1 commit intoTeamFlos:mainfrom
Open
fix: ensure hold is unaffected by incline or pos control events#688Naptie wants to merge 1 commit intoTeamFlos:mainfrom
Naptie wants to merge 1 commit intoTeamFlos:mainfrom
Conversation
Contributor
|
Could you please provide relevant chart for inspection? |
Contributor
Author
Here's a chart archive generated with RPE v1.7.0_a3 to demonstrate the behavior of incline and pos control events. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the existing function
now_transformin note.rs, where it no longer appliesincline_valandctrl_obj.posto Hold notes. This is consistent with the behavior seen in RPE.