Skip to content

fix: ensure hold is unaffected by incline or pos control events#688

Open
Naptie wants to merge 1 commit intoTeamFlos:mainfrom
Naptie:hold-ctrl-fix
Open

fix: ensure hold is unaffected by incline or pos control events#688
Naptie wants to merge 1 commit intoTeamFlos:mainfrom
Naptie:hold-ctrl-fix

Conversation

@Naptie
Copy link
Contributor

@Naptie Naptie commented Mar 6, 2026

This PR changes the behavior of the existing function now_transform in note.rs, where it no longer applies incline_val and ctrl_obj.pos to Hold notes. This is consistent with the behavior seen in RPE.

@Mivik
Copy link
Contributor

Mivik commented Mar 6, 2026

Could you please provide relevant chart for inspection?

@Naptie
Copy link
Contributor Author

Naptie commented Mar 6, 2026

Could you please provide relevant chart for inspection?

Here's a chart archive generated with RPE v1.7.0_a3 to demonstrate the behavior of incline and pos control events.
Line 0 has its posControl altered so that notes start to fall with the elastic out (index 24) curve from x=0 to their respective positions. Line 1 has an incline event with a non-zero value so you can see the different behaviors of Hold notes and other types of notes under the influence of it.
Incline and PosControl Test.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants