Update jcifs-ng to 2.1.10#4371
Merged
Merged
Conversation
To fix possibility of opening SMB connection causing Amaze to crash, due to AgNO3/jcifs-ng#342
EmmanuelMess
approved these changes
Mar 22, 2025
EmmanuelMess
left a comment
EmmanuelMess
left a comment
Member
There was a problem hiding this comment.
Lets hope no regressions are present in the library for this version
VishnuSanal
added
the
PR-Awaiting-Final-Review
VishnuSanal
approved these changes
Apr 14, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To fix possibility of opening SMB connection causing Amaze to crash, due to AgNO3/jcifs-ng#342
Upstream has fixes pushed to jcifs-ng 2.1.10.
Manual tests
Done
Device: Pixel 3 emulator
OS: Android 9
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck