Skip to content

Conversation

@lachlancollins
Copy link
Member

🎯 Changes

This project previously didn't work without moduleResolution node in the root-level tsconfig. I can't remember why (maybe TS versions?), but I think it will work now.

βœ… Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

πŸš€ Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2025

⚠️ No Changeset found

Latest commit: ed778af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Sep 22, 2025

View your CI Pipeline Execution β†— for commit ed778af

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... βœ… Succeeded 1m 13s View β†—
nx run-many --target=build --exclude=examples/** βœ… Succeeded 24s View β†—

☁️ Nx Cloud last updated this comment at 2025-09-22 12:10:54 UTC

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 90.35%. Comparing base (6892ed0) to head (ed778af).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1756   +/-   ##
=======================================
  Coverage   90.35%   90.35%           
=======================================
  Files          38       38           
  Lines        1752     1752           
  Branches      444      444           
=======================================
  Hits         1583     1583           
  Misses        149      149           
  Partials       20       20           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lachlancollins lachlancollins changed the title chore: try moduleResolution bundler chore(typescript): use moduleResolution bundler Sep 22, 2025
@lachlancollins lachlancollins merged commit 4a2bcfc into main Sep 22, 2025
4 of 5 checks passed
@lachlancollins lachlancollins deleted the module-resolution-bundler branch September 22, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants