[paced mutations]: Fix how we init AsyncQueuer#748
Closed
KyleAMathews wants to merge 3 commits intomainfrom
Closed
[paced mutations]: Fix how we init AsyncQueuer#748KyleAMathews wants to merge 3 commits intomainfrom
KyleAMathews wants to merge 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 0fc4748 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eeab839 to
91af66f
Compare
The AsyncQueuer constructor signature requires: 1. A function that processes each queued item as the first parameter 2. An options object as the second parameter The previous code incorrectly passed only the options object, causing TypeScript errors during type checking and builds: - Parameter 'task' implicitly has an 'any' type - Expected 0-1 arguments, but got 2 Fixed by: - Passing an async function as the first parameter that executes queued tasks - Adding explicit type annotation (task: () => Promise<void>) - Moving options to the second parameter This resolves the type check errors that were preventing builds from completing.
91af66f to
33ec8cc
Compare
The asyncQueue helper function provides the correct API for creating queued task processors, avoiding constructor signature issues with AsyncQueuer in @tanstack/[email protected].
c231b68 to
cbef440
Compare
Use AsyncQueuer constructor directly instead of asyncQueue helper to avoid type resolution issues on CI. The constructor API is more stable and works consistently across different TypeScript configurations.
927dd15 to
0fc4748
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AsyncQueuer constructor signature requires:
The previous code incorrectly passed only the options object, causing TypeScript errors:
Fixed by:
This resolves the type check errors that were appearing in test runs.
🎯 Changes
✅ Checklist
pnpm test:pr.🚀 Release Impact