Fixes #506, only adds camera with positive width and height#841
Open
PhilGauthier wants to merge 1 commit intoTadasBaltrusaitis:masterfrom
Open
Fixes #506, only adds camera with positive width and height#841PhilGauthier wants to merge 1 commit intoTadasBaltrusaitis:masterfrom
PhilGauthier wants to merge 1 commit intoTadasBaltrusaitis:masterfrom
Conversation
Owner
|
Ideally you would want to split this into two PRs, one for the bug fix with camera and another with additional functionality for streaming extra information. Furthermore, head pose-live demo is specifically done for a particular task of head pose extraction. I think it would be more useful (and not as confusing), is to add the streaming capability to the OpenFaceDemo executable. |
Author
|
You're right, I removed the second commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.