Fix CMake search path as subdirectory#540
Open
begroettrup wants to merge 1 commit intoTadasBaltrusaitis:developfrom
Open
Fix CMake search path as subdirectory#540begroettrup wants to merge 1 commit intoTadasBaltrusaitis:developfrom
begroettrup wants to merge 1 commit intoTadasBaltrusaitis:developfrom
Conversation
Owner
|
Thanks! Can you make the pull request to develop rather than master branch? |
Contributor
Author
|
Of course. Is it enough that I changed the base branch or should I open a new pull request? |
Owner
|
Changing the base branch should be enough. This should also fix the Travis CI, as the develop branch has a fix for the changes in the Mac OSX image in Travis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very small change to make CMake behave as I think was intended when OpenFace is used as subdirectory in a larger project.