-
Notifications
You must be signed in to change notification settings - Fork 54
Add batch video upload functionality #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
- Add new LectureCreateType.batchVodUpload enum for batch mode - Implement batch lecture management (add/remove rows) in form data - Add batch-specific UI in lecture details slide with multiple rows - Add batch-specific media upload slide for each lecture - Add batch upload progress tracking with per-lecture status - Reuse existing createVOD and uploadVODMedia endpoints - Include automatic rollback on batch upload failure
|
Now that I have finished everything I am not sure if this was what you meant by batch upload. I mean this makes it already quicker but how about uploading a folder/zip and allowing the lecturer to change the names afterwards?! Also just fyi i am pretty new to go, i have decent experience in html (web) but if you have any improvements in general or just style please lmk. |
|
@joschahenningsen Könnte jemand mal einen Blick hier drauf werfen, nur dass ich weiß was noch geändert werden soll? |
|
Hey Daniel, sorry, deine PR ist mir durchgerutscht! Ich schaue sie mir heute Abend an, vielen dank für die contribution. 🫶 |
joschahenningsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You really put lots of effort in this, and I think it's pretty clean! One thing I noticed is, that the "Record Lecture" screen also allows adding multiple lectures, but fails with "All lectures must have a start time!", which it shouldn't.
I'd argue, local recordings should not be possible as batches.
| const missingTitle = partialLectures.some((lec) => lec.title.trim().length === 0); | ||
| const missingStart = partialLectures.some((lec) => lec.start.trim().length === 0); | ||
| if (missingTitle) { | ||
| this.cannotContinueReason += "All lectures must have a title!\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a concern for us, actually most lectures don't have a title.
Motivation and Context
Allows lecturers to upload multiple video lectures at once instead of creating them one-by-one. This significantly improves the workflow when importing a batch of pre-recorded lectures (e.g., uploading an entire semester's worth of recordings).
Description
Adds batch video-on-demand (VOD) upload functionality to the lecture creation form, allowing users to create and upload multiple lectures with individual metadata and video files in a single workflow.
Resolves: #1617
Changes:
createVODanduploadVODMediaendpoints (no backend changes needed)Steps for Testing
Prerequisites:
Edge cases tested:
Screenshots
TumLive.Batch.Upload.mp4