[SNAP-1066] Fix for bug SNAP-1066 #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good, this is discussed with @sumwale also. testing done manually, observed only in sql script. covered in spark tests also. We should add a test using sql script in NorthWindTest so that these issues will be caught in precheckin itself |
suranjan
pushed a commit
that referenced
this pull request
Oct 12, 2016
* [SNAP-1066] Fix for bug SNAP-1066 * Modified existing tests to inferschema instead of using string and proper use of nullValue * Removed unused resource files
ashetkar
pushed a commit
that referenced
this pull request
Apr 20, 2021
* [SNAP-1066] Fix for bug SNAP-1066 * Modified existing tests to inferschema instead of using string and proper use of nullValue * Removed unused resource files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Patch testing
Ran precheckin some tests failed but they were not related to this changes
ReleaseNotes.txt changes
(Does this change require an entry in ReleaseNotes.txt? If yes, has it been added to it?) No
Other PRs
TIBCOSoftware/snappy-spark#12