Skip to content

Conversation

@mbabker
Copy link
Contributor

@mbabker mbabker commented Feb 5, 2023

Fixes #72

This PR does two things (the second dependent on the first to get a valid test environment)

  1. Updates the CI config to run tests on PHP 8.1 and 8.2, as well as Symfony 5.4 and 6.2 (skipping 6.0 and 6.1 as they are now EOL)
  2. Bumps the supported dependency ranges; Symfony 5.4 and 6.2-6.4, PHPUnit 9.6 and 10, and PHP 8.1+; some conditional code that's no longer needed is dropped
  3. Adds support for PHPUnit 10

@mbabker
Copy link
Contributor Author

mbabker commented Feb 5, 2023

Well, this is annoying.

PHPUnit uses exit code 1 if you need to migrate your phpunit.xml config, and that's the cause of all the failed builds. It can't be migrated without dropping old version support.

@emodric
Copy link
Contributor

emodric commented Mar 13, 2023

@mbabker Hi! Any progress on this?

@mbabker
Copy link
Contributor Author

mbabker commented Mar 13, 2023

Can't say I've put too much thought into the CI issue. The PHP changes are fine, the problem is getting PHPUnit to run with a compatible config file, and without bloating out the GitHub config, I'm not sure how to deal with it.

@emodric
Copy link
Contributor

emodric commented Mar 13, 2023

Why not drop old version support as you already mentioned? It's still valid as per semver to change dependencies in minor versions.

@mbabker
Copy link
Contributor Author

mbabker commented Mar 14, 2023

That'd definitely make maintenance easier to go down to 9.6+ (especially as PHPUnit 8 reached EOL with PHPUnit 10's release), but not my call to make.

@rpkamp
Copy link

rpkamp commented May 16, 2023

So whose call is it? @matthiasnoback ?

@matthiasnoback
Copy link
Collaborator

Hey! Tbh I'm not using this library myself. Also, I don't think we need to care too much about older versions. Please go ahead and modernize whatever you like. We can always release a new major version hehe.

@mbabker mbabker changed the title PHPUnit 10 support, CI updates Add support for PHPUnit 10; drop legacy PHP, PHPUnit, and Symfony support; CI updates May 18, 2023
@mbabker
Copy link
Contributor Author

mbabker commented May 18, 2023

Alright, the PR is now updated to the "let's ship a new major" iteration.

  • Require PHP 8.1
  • Require PHPUnit 9.6+
  • Require Symfony 5.4 or 6.2+

More modernization steps can be done in a later PR, I've just made minimal changes based on the raised minimums (i.e. compat code for Symfony 4 or ReflectionProperty::setAccessible() being no-op'd in PHP 8.1)

@matthiasnoback matthiasnoback merged commit 049e519 into SymfonyTest:master May 19, 2023
@mbabker mbabker deleted the phpunit-10 branch May 19, 2023 14:37
@matthiasnoback matthiasnoback mentioned this pull request May 19, 2023
3 tasks
@emodric
Copy link
Contributor

emodric commented Jun 2, 2023

Hi! Any news about releasing this patch?

@matthiasnoback
Copy link
Collaborator

Sorry, forgot to release it, v5.0.0 is available now.

@emodric
Copy link
Contributor

emodric commented Jun 2, 2023

Thanks @matthiasnoback <3

@emodric
Copy link
Contributor

emodric commented Jun 5, 2023

@matthiasnoback Is there any chance that https://github.com/SymfonyTest/SymfonyDependencyInjectionTest could be updated to allow this 5.0 release?

@mbabker
Copy link
Contributor Author

mbabker commented Jun 6, 2023

@matthiasnoback Is there any chance that https://github.com/SymfonyTest/SymfonyDependencyInjectionTest could be updated to allow this 5.0 release?

SymfonyTest/SymfonyDependencyInjectionTest#148 is a step in that direction.

@emodric
Copy link
Contributor

emodric commented Jun 6, 2023

@mbabker Thanks for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

not compatible with phpunit 10.0

4 participants