-
Notifications
You must be signed in to change notification settings - Fork 35
Add support for PHPUnit 10; drop legacy PHP, PHPUnit, and Symfony support; CI updates #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Well, this is annoying. PHPUnit uses exit code 1 if you need to migrate your |
|
@mbabker Hi! Any progress on this? |
|
Can't say I've put too much thought into the CI issue. The PHP changes are fine, the problem is getting PHPUnit to run with a compatible config file, and without bloating out the GitHub config, I'm not sure how to deal with it. |
|
Why not drop old version support as you already mentioned? It's still valid as per semver to change dependencies in minor versions. |
|
That'd definitely make maintenance easier to go down to 9.6+ (especially as PHPUnit 8 reached EOL with PHPUnit 10's release), but not my call to make. |
|
So whose call is it? @matthiasnoback ? |
|
Hey! Tbh I'm not using this library myself. Also, I don't think we need to care too much about older versions. Please go ahead and modernize whatever you like. We can always release a new major version hehe. |
|
Alright, the PR is now updated to the "let's ship a new major" iteration.
More modernization steps can be done in a later PR, I've just made minimal changes based on the raised minimums (i.e. compat code for Symfony 4 or |
|
Hi! Any news about releasing this patch? |
|
Sorry, forgot to release it, v5.0.0 is available now. |
|
Thanks @matthiasnoback <3 |
|
@matthiasnoback Is there any chance that https://github.com/SymfonyTest/SymfonyDependencyInjectionTest could be updated to allow this 5.0 release? |
SymfonyTest/SymfonyDependencyInjectionTest#148 is a step in that direction. |
|
@mbabker Thanks for your efforts! |
Fixes #72
This PR does two things (the second dependent on the first to get a valid test environment)