Fix macOS 14 CI build by adding glm to test targets#3416
Fix macOS 14 CI build by adding glm to test targets#3416Copilot wants to merge 4 commits intogithub-actions-update-macos-versionfrom
Conversation
Co-authored-by: tobbi <583169+tobbi@users.noreply.github.com>
tobbi
left a comment
There was a problem hiding this comment.
No, the build still fails. Also, please don't mess with CMAKE_PREFIX_PATH. It's not common practice.
Co-authored-by: tobbi <583169+tobbi@users.noreply.github.com>
Reverted the workflow file change and moved the fix to |
tobbi
left a comment
There was a problem hiding this comment.
Hello @copilot . I just finished looking at the latest build and look and behold, what do I see:
/Users/runner/work/supertux/supertux/src/math/vector.hpp:21:10: fatal error: 'glm/glm.hpp' file not found
#include <glm/glm.hpp>
So, this didn't really help, did it?
Co-authored-by: tobbi <583169+tobbi@users.noreply.github.com>
... Found the root cause: the test targets |
tobbi
left a comment
There was a problem hiding this comment.
I think it worked this time! Can you do me favour and rebase this PR against the github-actions-update-macos-version branch again? I made some changes there that should help.
macOS 14 runners use Apple Silicon where homebrew installs to
/opt/homebrew/instead of/usr/local/. CMake couldn't find GLM headers during test compilation.Root Cause:
The test targets
AATriangleTestandCollisionTestwere missingglmin theirLIBRARIESlist. Without this, CMake doesn't set up the include paths for GLM headers.Changes:
glmto theLIBRARIESlist forAATriangleTestandCollisionTestintests/unit/CMakeLists.txtThis ensures the test targets properly inherit the GLM include directories from the
glmtarget created byadd_package.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.