ENH: Upgrade cmake_minimum_required from 2.8 to 3.10.2 #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Supersedes (at least partially) pull request #46 "Fix CMake warnings + drop old style export of library" |
Member
|
i see no problems with that
Leiden University Medical Center | Division of Image Processing (LKEB), Department of Radiology | PO Box 9600 | 2300 RC Leiden | The Netherlands | Postzone C2-s, room C3-53 | +31 (0)71 52 62137
…________________________________
From: Niels Dekker <[email protected]>
Sent: 21 August 2020 5:04 PM
To: SuperElastix/elastix
Cc: Staring, M. (RADI); Review requested
Subject: Re: [SuperElastix/elastix] ENH: Upgrade cmake_minimum_required from 2.8 to 3.10.2 (#263)
@N-Dekker<https://github.com/N-Dekker> requested your review on: #263<#263> ENH: Upgrade cmake_minimum_required from 2.8 to 3.10.2.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#263 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAFRMFBHZKE26GTIV7MFMELSB2EHJANCNFSM4QHKMTEA>.
|
Member
Author
|
Thanks @mstaring It appears that even the very first release of ITK 5.0 requires CMake 3.10.2: https://github.com/InsightSoftwareConsortium/ITK/blob/v5.0.0/CMakeLists.txt#L13 I'll merge this PR. Still have to look at the CMake warnings later... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.