BUG: Remove bounds check from ImageMaskSpatialObject2 IsInside #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check if not `GetBounds()->IsInside(point)` appears to make `ImageFullSampler` sensitive to rounding errors. These rounding errors are caused by a subtle difference between ITK's `ImageBase::TransformIndexToPhysicalPoint` (called by elastix ImageFullSampler) and ITK's `MatrixOffsetTransformBase::TransformPoint` (called by elastix ImageMaskSpatialObject2). This commit should fix issue #153 "ImageFullSampler with ImageMaskSpatialObject2 misses some pixels" Related to pull request #147 "ENH: Replace elastix ImageSpatialObject2 by ITK ImageSpatialObject"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check if not
GetBounds()->IsInside(point)appears to makeImageFullSamplersensitive to rounding errors.These rounding errors are caused by a subtle difference between ITK's
ImageBase::TransformIndexToPhysicalPoint(called by elastix ImageFullSampler) and ITK'sMatrixOffsetTransformBase::TransformPoint(called by elastix ImageMaskSpatialObject2).This commit should fix issue #153 "ImageFullSampler with ImageMaskSpatialObject2 misses some pixels"
Related to pull request #147 "ENH: Replace elastix ImageSpatialObject2 by ITK ImageSpatialObject"