fix: correct HELM_INSTALL_ARGS placement and CLUSTER_CHART_REPO in templates

[Copilot]

Two bugs in the new Makefile templates cause helm args to be silently dropped and cluster chart repos to be ignored.

Fixes

• base.mk — HELM_INSTALL_ARGS never reached helm: Args were appended after the shell redirect and error handler, so the shell parsed them as arguments to the exit 1 subshell rather than flags to helm upgrade. Breaks opik's --set component.*.image.tag=... version pinning entirely.

  # Before — args after redirect, ignored by helm
  --values $(HELM_VALUES_FILE) > output.log 2>&1 || (cat output.log && exit 1) \
  $(if $(HELM_INSTALL_ARGS),$(HELM_INSTALL_ARGS),)
  
  # After — args before redirect
  --values $(HELM_VALUES_FILE) \
  $(if $(HELM_INSTALL_ARGS),$(HELM_INSTALL_ARGS),) \
  > output.log 2>&1 || (cat output.log && exit 1)

• operator.mk — CLUSTER_CHART_REPO defined but never used: install-cluster hardcoded $(HELM_CHART_REPO), ignoring the CLUSTER_CHART_REPO variable set in cassandra, flink, mysql, and nebulagraph. Changed to $(if $(CLUSTER_CHART_REPO),$(CLUSTER_CHART_REPO),$(HELM_CHART_REPO)) and added the variable to the comments block.

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.