Add logs-generator #117
Merged
Add logs-generator #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
requested review from
andrzej-stencel,
kasia-kujawa,
perk-sumo and
pmalek-sumo
as code owners
sumo-drosiek
force-pushed
the
drosiek-logs-generator
branch
6 times, most recently
from
8a043e4 to
c2d9cc7
Compare
2 tasks
pmalek-sumo
reviewed
Apr 8, 2021
Contributor
Author
|
@perk-sumo Could we drop travis integration? |
pmalek-sumo
reviewed
Apr 21, 2021
| fn save_log(mut fd: &File, log: &String) -> u64 { | ||
| let write = fd.write_all(log.as_bytes()); | ||
| match write { | ||
| Ok(_result) => { |
Contributor
There was a problem hiding this comment.
What is this rust wizardry? _err and _result are magic variable accessible when a function returns a Result?
Contributor
Author
There was a problem hiding this comment.
I believe this would be better explanation, than me trying to do that :D. doc
| } | ||
|
|
||
| fn get_random_word(wordlist: &Vec<String>) -> &String { | ||
| let mut rng = rand::thread_rng(); |
Contributor
There was a problem hiding this comment.
Not really so important but I guess this can somehow be initialized just once? Are there static variables in rust?
Contributor
Author
There was a problem hiding this comment.
It ends with
error[E0133]: use of mutable static is unsafe and requires unsafe function or block
| random_words: u32, | ||
| random_digits: u32, | ||
| ) -> String { | ||
| let mut rng = rand::thread_rng(); |
sumo-drosiek
force-pushed
the
drosiek-logs-generator
branch
from
8e031f8 to
3832858
Compare
Signed-off-by: Dominik Rosiek <[email protected]> Co-authored-by: Patryk Małek <[email protected]>
sumo-drosiek
force-pushed
the
drosiek-logs-generator
branch
from
3832858 to
9c5791f
Compare
pmalek-sumo
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See src/rust/logs-generator/README.md