Skip to content

Settings: Improve completions of known values #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FichteFoll merged 3 commits into from
Sep 19, 2019
Merged

Settings: Improve completions of known values #258

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9245ef8
Settings: Fix syntax specific encoding completions
Sep 19, 2019
40af420
Settings: Fix default color_scheme and theme marking
Sep 19, 2019
3f61a04
Settings: Add support for sublime-color-scheme completions
Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions plugins_/settings/known_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,12 +708,18 @@ def _color_scheme_completions(default):
"""
hidden = get_setting('settings.exclude_color_scheme_patterns') or []
completions = set()
for scheme_path in sublime.find_resources("*.sublime-color-scheme"):
if not any(hide in scheme_path for hide in hidden):
_, package, *_, name = scheme_path.split("/")
completions.add(format_completion_item(
value=name, is_default=name == default, description=package))

for scheme_path in sublime.find_resources("*.tmTheme"):
if not any(hide in scheme_path for hide in hidden):
_, package, *_, file_name = scheme_path.split("/")
_, package, *_, name = scheme_path.split("/")
completions.add(format_completion_item(
value=scheme_path, is_default=scheme_path == default,
label=file_name, description=package))
label=name, description=package))
Copy link
Member

@FichteFoll FichteFoll Sep 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I see this, tmTheme files need to be specified by path, not by name. I'll fix this. Nvm, the value is still correct.

return completions

@staticmethod
Expand Down