Project: Fix Build Systems mapping #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `build_systems` dictionary in a sublime-project file does not contain a build system variant, but a list of full featured build systems. This means `selector` is a valid key. Additionally the `name` key is used to identify the build system. Note: The completions selectors might need to be tweaked a bit as some glitches were encountered. main keys are suggested within the `cmd` value part for instance. Looks like another issue.
Member
|
Thanks for the PR and the report. Fixed the completions issues (minus the exception mentioned in the commit message) in 875292a. |
FichteFoll
added a commit
that referenced
this pull request
Jul 4, 2019
Notably, exclude keys from cmd sequence and generalize main key scopes so that they work inside projects and we don't need to specify the main key completions twice. Only minor "bug" left is that exec keys are shown inside the variants sequence outside of the mapping. Reported in #250.
FichteFoll
added a commit
that referenced
this pull request
Jul 4, 2019
Notably, exclude keys from cmd sequence and generalize main key scopes so that they work inside projects and we don't need to specify the main key completions twice. Only minor "bug" left is that exec keys are shown inside the variants sequence outside of the mapping. Reported in #250.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
build_systemsdictionary in a sublime-project file does notcontain a build system variant, but a list of full featured build
systems.
This means
selectoris a valid key. Additionally thenamekey isused to identify the build system.
Note:
The completions selectors might need to be tweaked a bit as some
glitches were encountered. main keys are suggested within the
cmdvalue part for instance. Looks like another issue.