Skip to content

Conversation

@un1versal
Copy link
Contributor

@un1versal un1versal commented Jul 22, 2016

centered looks off this is how it looks best to me

added gitter button too. maybe should put under contact area in readme?

@silverwind I know you tried this before...

https://github.com/un1versal/GitHub-Dark/blob/They-Call-Me-Mellow-Yellow/README.md

@silverwind
Copy link
Member

Sorry, but that logo just doesn't fit there in my eyes. I don't think there's an acceptable solution for it. The button changes are fine though.

@Mottie
Copy link
Member

Mottie commented Jul 23, 2016

It'd look better with a wider logo.

@un1versal
Copy link
Contributor Author

un1versal commented Jul 23, 2016

Oh yea, thats lovely, but I like simple

with bg
githubdark

without bg
githubdark-transparent

the last without outline (looks like the cats meow on styled and unstyled github

githubdark-drk-tr

@un1versal un1versal force-pushed the They-Call-Me-Mellow-Yellow branch 3 times, most recently from 3aff733 to bc979dc Compare July 23, 2016 01:09
@un1versal
Copy link
Contributor Author

new readme updated with that for a better preview https://github.com/un1versal/GitHub-Dark/blob/They-Call-Me-Mellow-Yellow/README.md

@un1versal un1versal force-pushed the They-Call-Me-Mellow-Yellow branch from bc979dc to 3c1a32b Compare July 23, 2016 01:32
@Mottie
Copy link
Member

Mottie commented Jul 23, 2016

I think it should match our logo a bit more... something like this:

ghd-logo

@un1versal
Copy link
Contributor Author

mmm no

@un1versal
Copy link
Contributor Author

githubdark-ish

not doing anymore thats it

@un1versal un1versal force-pushed the They-Call-Me-Mellow-Yellow branch from 3c1a32b to 7a7ea4d Compare July 23, 2016 02:55
@un1versal
Copy link
Contributor Author

Sorry, but that logo just doesn't fit there in my eyes. I don't think there's an acceptable solution for it. The button changes are fine though.

@silverwind is that still the case? or can I just close this?

@silverwind
Copy link
Member

silverwind commented Jul 24, 2016

Hmm, I actually quite like you latest iteration. How about centering it like here. You'd need to change the buttons to <a> to center them too.

@un1versal
Copy link
Contributor Author

un1versal commented Jul 24, 2016

Hmm, I actually quite like you latest iteration. How about centering it like here. You'd need to change the buttons to to center them too.

I dislike centered because changing all those buttons from markdown to HTML is a pita when they break, and finding out why I loose interest fast.

but youre welcome to have at it, merge it and mod it to your liking

@Mottie Mottie merged commit 4756be0 into StylishThemes:master Jul 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants