Heavy check mark (✔) hard to see on black background

[leoj3n]

The check mark "✔" is nearly invisible. Is this to be expected or something to be fixed?

Any other unicode characters that need to be considered?

http://graphemica.com/%E2%9C%94

[silverwind]

Not sure we can do anything about colored unicode, unless there's a way for CSS to select single letters. Even then, I'm not sure you can filter: invert text like that.

GitHub's image emoji are already handled by the way: ✔️

[silverwind]

We might be able to use unicode-range to override the affected codepoints. Anyone care to compile a list of dark unicode characters?

[Mottie]

Do you have an example of where the checkmark is being used? The network graph is the only place we use #000 as a background color.

[leoj3n]

@Mottie https://github.com/mauricecruz/zero-base-themes#notice

[Mottie]

This is what I see on that page (110% zoom)

Are you seeing something different?

[leoj3n]

Google Chrome Canary on OS X

[Mottie]

Ahh, so the text is being replaced. Would you copy/paste the image element here.

[Mottie]

Hmm, @silverwind can you see what you can do... I don't own an Appl€ device, so...

[leoj3n]

Doesn't look like an image from Developer Tools inspector (above). Setting an inline text color of the <p> with !important doesn't affect the check mark on GitHub. If I do so on, say google.com, the check mark does respect the style and inherits the color. Strange.

[silverwind]

Well, these are unicode glyphs. Github uses system fonts so the rendered glyph will be dependant on the OS. I'd say this is more of a design issue of Apple's glyphs than an issue specific to this style.

I assume Google uses a Webfont that has the color-respecting property of the glyph set.

[leoj3n]

Looks like this is the culprit:

.markdown-body {
  font-family: "Helvetica Neue", Helvetica, "Segoe UI", Arial, freesans, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol";
}

If I change that to just:

.markdown-body {
  font-family: "Helvetica Neue";
}

the heavy check mark is rendered like normal.

[silverwind]

Should be fixed, thanks!

[silverwind]

Apple

©®™▪◼◾♠♣✔✖➕➖➗➰⬛〰

Segeo and Apple

🎶🎼💱💲🔃🔙🔚🔛🔜🔝

Non-Emoji

©®™▪◼♠♣✔✖〰

Emoji

➕➖➗➰◾⬛🎶🎼💱💲🔃🔙🔚🔛🔜🔝