Wrong icon color for closed issues in Notifications view

[simov]

Obviously this makes it harder to see the closed issues quickly.

Also this may apply for PRs as well (the PR icon) but I don't have such example at the moment.

[silverwind]

Looks like the fix in f091ead wasn't done properly, I'll have a look.

[silverwind]

Let me know if that works, I don't have any unread notifications right now.

[silverwind]

Had a typo, sorry.

[simov]

Seems to be working:

For PRs I think they can be either:

• green: proposed
• red: closed (without being merged)
• purple: merged

So if a comment arrives in a PR, the color of the icon should be one of the above based on the state of the PR (but currently I don't have such cases to prove it or show it you).

[silverwind]

All colors should be there now. I took care to include purple (state-merged) and grey (state-none). Thanks!

[simov]

Thanks 👍

[Mottie]

Doh, it looked good to me... oh well. Thanks for fixing it @silverwind.

Oh and if you don't have any unread notifications, go to the "All notifications" tab then open the console and type in:

$('.list-group-item').removeClass('read').addClass('unread');