Code links

[Mottie]

I was posting some code which linked back to documentation and noticed that the link was not being styled; there is no indication that it is a link except for hovering over it:

linked code

I'm not sure if making it match the base color would be a good idea, but maybe we could at least underline it? What do you guys think?

[silverwind]

Definitely a bug if it's colored with the style disabled, looking into it.

[silverwind]

Well that was easy, but may affect other code tags, I must've put it there for a reason, but I don't remember right now.

[silverwind]

Hmm, underline still missing.

[silverwind]

Strange that it doesn't underline on hover, given that we don't touch text-decoration. There's a:hover, a:active { text-decoration: underline } in GH's sheet.

@Mottie could you have a look in Chrome's DevTools? Firefox still shows the underline in computed styles, but doesn't render it.

[Mottie]

Hmm, I'm not seeing where the text-decoration is being changed, when I click on the code block, I do see this entry show up in the user agent stylesheet

a:-webkit-any-link {
  color: -webkit-link;
  text-decoration: underline;
  cursor: auto;
}

If I add this css (even without the !important flag) to the stylesheet, it appears to work:

a:hover code {
  text-decoration: underline;
}

But my question still is about the text color. There isn't any syntax highlighting, so should we leave the text off-white or the base color?

[silverwind]

so should we leave the text off-white or the base color?

My general rule of thumb is, if it's colored without the style, it should be colored with the style, so base color seems fine to me.

[Mottie]

Ok, sounds reasonable 😸

[silverwind]

This underline thing smells like a Firefox bug to me, or a spec misbehaviour in Chrome, or both. I'm not sure if that property shall be inherited by child elements att all. Setting

a:hover code {text-decoration: underline !important}

does fix it, but I'm afraid this might have side-effects on other parts of the site. Hmm.

[silverwind]

I have an idea on how to fix this without causing too much side-effects.

[silverwind]

Please check if you still have the underline on hover in Chrome.

[Mottie]

Sorry, I've been doing a lot of running around today... yeah that is working just fine :P