Not applying on self-hosted GitHub Enterprise

[EnzoMartin]

The recent updates have made this (awesome) theme not apply to self-hosted GitHub Enterprise, the fix is fairly simple as it's just changing the URL regex to match on github. instead of specifically targeting github.com:

^https?://((raw[2-9]*|gist|guides|help|status|developer).)?github.*

(I've already applied this locally)

[silverwind]

Which domain does GitHub use for enterprise?

The reason I'm asking is, that I don't want to style github.io stuff, for example, so the regex should be as specific as possible.

[EnzoMartin]

Ah, yea I see what you're saying.

Unfortunately it is fully configurable by whomever installs it, for example we use github.<bunch of internal sub-domains>.com

There's a few differences in the CSS and HTML classes in the Enterprise version as well, I was thinking of doing a pull request later this week to add support for them, if you're interested in supporting GitHub Enterprise.

[ddavison]

I'm not sure if we could support that.. we have the option of doing custom options in the theme, but there would be no way "out-of-the-box" to support a different URL unfortunately. We'd of course love doing that, but I just don't see a viable way to do it, other than after theme installation, you go in and add your own url regex

[silverwind]

@ddavison I'm not sure where you're getting at. A simple regex change would work in this case.

[ddavison]

@silverwind I meant manually editing the style. this bit:

@-moz-document regexp("^https?://((raw[2-9]*|gist|guides|help|status|developer).)?github.com.*") {
/* Github Dark Theme v1.8.5 (3/7/2014)

I don't think we can add an option on the stylish install page to let people specify a custom url.

possibly even just adding the internal ip as a custom url. my point is, i think that's the only option.

[silverwind]

How about this one:

^https?://((raw[2-9]*|gist|guides|help|status|developer).)?github.*\..*

Matches http://github.com http://github.something.com

There may be false positives for any host which uses a github subdomain, hmm.

[ddavison]

exactly why i was thinking this is going to be tough to work with, and it might just be worth having the person add their custom url :)

[silverwind]

@EnzoMartin78 Are there any other parts in these URL where we could identify such a enterprise site?

[ddavison]

like ?enterprise=true LOL

[silverwind]

Yep, something like that, but it's probably not present. I think we can still include specific styling, but we should notice users to include their company's github domain if they have one in the README.

[EnzoMartin]

Unfortunately no, there's no other identifier in the URL.

Thinking about the URL issue you guys brought up though, I doubt you'd be running a regular site with https (ex: github.io is http and not https) so letting it detect github. might actually be a non-issue?

[silverwind]

Still, I think that expanding our regex to cover any github subdomain on any domain is going to far, our style would be semi-global. I'd opt for a small note in the README.

@Mottie any opinions on this?

[Mottie]

I'm leaning toward agreeing with @silverwind, the regex should only target github.com, and not github.io. If we expand the regex to allow github as a subdomain, it may catch other unintended sites.

Maybe a solution would be to add an additional @moz definition (ref) instead of modifying the regex.

[ddavison]

it should be targeted at github.*\.com or whatever @silverwind said (too lazy to look back) because .com can be the same as .io. For example, http://ddavison.github.com goes to http://ddavison.github.io (just for safety)

[silverwind]

Actually you're forgetting that it doesn't have to be .com. Let's stay a company uses github.mydomain.net. We can only look for the github. part, which in my opinion is far too rough of a selector. And, according to OP, it seems that even the github. part can be different.

There's just no way we can make this work generally, except maybe a global userscript which scans for matching id's.