Use "immediate" instead of "set-immediate-shim"#716
Closed
antimatter15 wants to merge 1 commit intoStuk:mainfrom
Closed
Use "immediate" instead of "set-immediate-shim"#716antimatter15 wants to merge 1 commit intoStuk:mainfrom
antimatter15 wants to merge 1 commit intoStuk:mainfrom
Conversation
johnfactotum
added a commit
to johnfactotum/foliate
that referenced
this pull request
Apr 1, 2021
The fixed file is from `dist/jszip.js` from Stuk/jszip#716.
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Apr 3, 2021
Changes since 2.6.2:
2.6.3
Changes:
* Fixed a performance issue with zipped files (including EPUB files)
(Stuk/jszip#716)
rozhuk-im
pushed a commit
to rozhuk-im/freebsd-ports
that referenced
this pull request
Apr 6, 2021
Changes since 2.6.2:
2.6.3
Changes:
* Fixed a performance issue with zipped files (including EPUB files)
(Stuk/jszip#716)
|
@antimatter15 This is already fixed in v3.10.0 ( PR #829 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using ExcelJS to parse a XLSX file recently and noticed that it was taking a lot of time because the particular set-immediate-shim being used in JSZip is very inefficient on browsers that don't natively implement setImmediate (which is, with the deprecation of IE, every modern browser). With this change applied, it cuts down the parsing time for Excel files by over 30%!
jszip already depends on lie for promises, which in turn depends on immediate - which is a much better set-immediate polyfill that uses different techniques so it doesn't create long spans of idle time. By swapping out set-immediate-shim for immediate, the bundler is able to use the same package for both and JSZip actually becomes smaller.
This PR only changes a single line- it changes require('set-immediate-shim') into require('immediate').