feat(settings): save playback speed and volume #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tymmesyde
reviewed
Oct 7, 2025
| pub server_in_foreground: bool, | ||
| pub send_crash_reports: bool, | ||
| pub volume: u8, | ||
| pub playback_speed: i16 |
Member
There was a problem hiding this comment.
this should be f32 and default value set to 1.0
Author
There was a problem hiding this comment.
I think volume should probably stay as u8 just like subtitles_opacity
Author
There was a problem hiding this comment.
I also forgot the mention but the reason it's an i16 is because I would need to modify a lot of files to remove the Eq trait so should I keep it as i16 instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.