Add mask to rule 1 and rule 3#340
Merged
Merged
Conversation
- Update deye_hybrid.yaml to use mask for time of use enable registers
|
Works like a charm. Thanks. Also have a 8 kW Deye. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a DEYE 8kW inverter and for some of the registers where a 0 or 1 is expected, mine does not return a 0 or a 1, resulting in a LOOKUP string as the state of the enity. I saw however that bit 0 in those registers is the bit of interest. This PR adds a mask to the unsigned rules (1 & 3) so you can mask the required bit or bits. A possible further improvement can be adding a shift, so you can mask a bit or bits in the middle of the register value and shift it down (this has not been added in this PR)