Skip to content

Fix race condition in waitForPopupClose #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JGJP merged 1 commit into from
Apr 7, 2026
+3 −0
Merged

Fix race condition in waitForPopupClose #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions e2e/lib/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,11 @@ export const waitForPopup = async (

/**
* Wait for a popup to close (e.g. after auth completes).
* Guards against race: if the popup already closed before this is called,
* waitForEvent('close') would hang forever.
*/
export const waitForPopupClose = async (popup: Page): Promise<void> => {
if (popup.isClosed()) return
await popup.waitForEvent('close')
}

Expand Down
Loading