Add new Helm value setting 'st2.apikeys' to import ST2 API keys #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d list of ST2 API keys
Member
Author
|
The feature in K8s/HA is ready, however it's blocked by ST2 regression when Similar bug was fixed before, but it reappeared for some new reason. |
warrenvw
approved these changes
Feb 8, 2019
Contributor
warrenvw
left a comment
warrenvw
left a comment
There was a problem hiding this comment.
Looks good, but left a comment.
There's also a #TODO on L31 templates/jobs.yaml. You going to address that in this PR, or later?
| volumeMounts: | ||
| - name: st2client-config-vol | ||
| mountPath: /root/.st2/ | ||
| # `st2 login` doesn't exit on failure correctly, use old methods instead. See bug: https://github.com/StackStorm/st2/issues/4338 |
Contributor
There was a problem hiding this comment.
Apparently st2 login now exits properly on failure. StackStorm/st2#4338 was closed by StackStorm/st2#4390.
Member
Author
|
Can now confirm the fixed behavior and working Helm values functionality after getting new Docker images based on latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36
Implements https://docs.stackstorm.com/authentication.html#api-key-migration mechanism to import previously exported list of ST2 API keys that's needed for reproducible deployments.