Skip to content

Conversation

@Ein-nor
Copy link
Contributor

@Ein-nor Ein-nor commented Nov 6, 2023

The following changes have been made:

  • Update to latest CircleCI orb versions
  • Switch image from ubuntu-2204:2022.10.2 to ubuntu-2204:current to have always the latest ubuntu version
  • Increase helm install timeout to 20 minutes
  • Update to latest k8s and remove unsupported versions

- circleci/[email protected]
- circleci/[email protected]
- machine image ubuntu-2204:current
- minikube v1.31.2
- latests kubernetes versions
- remove unsupported k8s
- Update CHANGELOG.md
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Nov 6, 2023
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines. Good size to review. and removed size/S PR that changes 10-29 lines. Very easy to review. labels Nov 6, 2023
@arm4b arm4b added the enhancement New feature or request label Nov 6, 2023
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updates!

A couple of changes requested to address

- run:
name: Helm install stackstorm-ha chart
command: helm install --timeout 10m0s --debug --wait --name-template stackstorm-ha .
command: helm install --timeout 20m0s --debug --wait --name-template stackstorm-ha .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any evidence that lifting install timeout helps.
Usually from the history of CI failures if deployment didn't complete in ~5mins, everything goes into a crash loop which is rarely recoverable without a manual intervention.
The usual reason behind the crash loop is one of the backend clusters didn't startup correctly like MongoDB, Redis or RabbitMQ.

But let's see if this helps.
Please use at least 15m everywhere as bumping to 20mins is too much!

Suggested change
command: helm install --timeout 20m0s --debug --wait --name-template stackstorm-ha .
command: helm install --timeout 15m0s --debug --wait --name-template stackstorm-ha .

CHANGELOG.md Outdated

## In Development
* Bump to latest CircleCI orb versions (by @ZoeLeah)
* Remove unsupported k8s Versions (by @ZoeLeah)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention explicitly (eg. 26,27,28) the new K8s versions that are used for testing this Helm chart.
That would provide a better info for someone reading the Changelog and thinking if particular K8s version is supported or not.

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the K8s refresh!

Comment on lines +4 to +9
* Bump to latest CircleCI orb versions ([email protected] and [email protected] by @ZoeLeah)
* Remove unsupported k8s Versions (1.24.x and 1.25.x by @ZoeLeah)
* Update and add new K8s versions (1.28.3, 1.27.7 and 1.26.10 by @ZoeLeah)
* Switch from ubuntu-2204:2022.10.2 to ubuntu-2204:current (by @ZoeLeah)
* Update K3s to v1.28.3+k3s1 (by @ZoeLeah)
* Increase helm install timeout to 15 minutes (by @ZoeLeah)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's too much of the changelog details for a single PR 😃 (balance is the key), but let's go with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size/M PR that changes 30-99 lines. Good size to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants