-
-
Notifications
You must be signed in to change notification settings - Fork 117
Migrate to Helm v3, Change dependencies from deprecated official helm charts to Bitnami charts #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This likely needs a good test before its accepted into the branch, I have given it the best tests I can in the environments I have available to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Great work with details: Helm values for dependencies and connection strings. 👍
I provided a few comments to address and let's see if we could get the CI e2e tests happy first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
Let's try to fix the CI so it works with Helm v3. I left a few pointers in the comments.
Removed Parallel due to no support helm/helm#7763
… feature is available again
|
Found another potential issue running upgrade with helm.. I can't decide if this is an error or configuration, maybe config Error: UPGRADE FAILED: template: stackstorm-ha/charts/mongodb/templates/NOTES.txt:192:4: executing "stackstorm-ha/charts/mongodb/templates/NOTES.txt" at <include "common.errors.upgrade.passwords.empty" (dict "validationErrors" (list |
|
Ok sorted that now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow, e2e CI tests are green under Helm v3 👍 @Christopher-Russell That's a ton of great work!
I left a few more minor comments below.
|
Also please check the https://github.com/StackStorm/stackstorm-ha#requirements README section, - that needs an update too following Helm v3 migration. |
Co-authored-by: Eugen Cusmaunsa <[email protected]>
Co-authored-by: Eugen Cusmaunsa <[email protected]>
Co-authored-by: Eugen Cusmaunsa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Christopher-Russell Thanks a lot for the contribution! It's massive effort and great work here! 👍
I'm approving this PR and planning to merge it closer to the v0.50.0 release due to its breaking change nature.
I'd also welcome more community testing for this PR.
| * Drop Helm `v2` support and fully migrate to Helm `v3` (#163) | ||
| * Switch dependencies from deprecated `helm/charts` to new Bitnami Subcharts (#163) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Christopher-Russell Feel free to also include your name or nickname here as someone who contributed this work.
# Conflicts: # .circleci/config.yml # Chart.yaml # requirements.yaml
Closes #154
Closes #98