Skip to content

Conversation

@kroustou
Copy link
Contributor

No description provided.

@amanda11
Copy link
Contributor

amanda11 commented Jan 24, 2021

Thanks so much for the contribution, it's a great start.

It looks like there are some problems with the pip upgrade, as if I use image built from these changes to run st2-packages and build. It then fails when it runs:
/usr/bin/python3 ../scripts/fixate-requirements.py -s in-requirements.txt -f ../fixed-requirements.txt

which looks to be because of the change in pip - the newer pip doesn't work with our fixate-requirements.py:

[bdist: st2api]      /usr/bin/python3 ../scripts/fixate-requirements.py -s in-requirements.txt -f ../fixed-requirements.txt
[bdist: st2api]      Traceback (most recent call last):
[bdist: st2api]        File "../scripts/fixate-requirements.py", line 213, in <module>
[bdist: st2api]          skip=skip)
[bdist: st2api]        File "../scripts/fixate-requirements.py", line 144, in write_requirements
[bdist: st2api]          requirements = merge_source_requirements(sources)
[bdist: st2api]        File "../scripts/fixate-requirements.py", line 121, in merge_source_requirements
[bdist: st2api]          if req.req:
[bdist: st2api]      AttributeError: 'ParsedRequirement' object has no attribute 'req'
[bdist: st2api]      make: *** [.stamp-requirements] Error 1

I'm not sure whether this means that to be able to upgrade pip we need to amend the fixate-requirements.py or if there is a way to use newer pip for the virtualenvs but still use the older pip for this part. Need some advice from others that know more about the buliding process.

@kroustou
Copy link
Contributor Author

Okay waiting on your feedback. Thank you and sorry for the delays i have been really busy lately :)

@arm4b
Copy link
Member

arm4b commented Jan 30, 2021

As @amanda11 identified, the pip/virtualenv upgrades might be more involved, your work is proceeding here StackStorm/st2#5123 and #98.

Thanks @kroustou for starting this story!

@kroustou
Copy link
Contributor Author

Thank you very much for your hard work

@amanda11 amanda11 modified the milestones: 3.4.0, 3.5.0 Feb 15, 2021
@amanda11
Copy link
Contributor

amanda11 commented Apr 6, 2021

@kroustou I think this has been superseded by changes committed to master under PR #98

@kroustou kroustou closed this Apr 11, 2021
@kroustou kroustou deleted the 5060/upgrade_vritualenv branch April 11, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants