Update notes entry for new dynamic runner loading #807
Conversation
docs/source/upgrade_notes.rst
Outdated
|
|
||
| This provides for more flexible installation and loading of runner modules. To install a custom | ||
| runner, user now just needs to install Python package which contains runner module into |st2| | ||
| virtual environment and run ``sudo st2ctl reload --register-runners`` command. |
There was a problem hiding this comment.
Just to be sure I'm understanding it right, default runners that we package in core don't need additional st2ctl reload --register-runners and would work by default on app init?
There was a problem hiding this comment.
This command still needs to be run so the information from disk is stored in the database (same as for any other resources).
In the future though, we could make that step implicit and happen automatically on service start up (like it used to be the case).
There was a problem hiding this comment.
In this case, it sounds like a regression to me 👎
While ideally to go towards pre-init all the content that comes with st2 core on app startup, making the st2 self-sufficient and minimally working after the first installation (and that affects all deployments), we sadly go the opposite side offloading repetitive instructions on user's shoulders adding more complexity.
There was a problem hiding this comment.
It's not a regression - it's exactly the same end user behavior, just the internals change.
While I would prefer if we could get rid of it, we need to approach it in incremental steps.
There was a problem hiding this comment.
Having said that, I will see what we can do.
That st2 PR is already growing a bit big and I would like to scope things down.
Upgrade notes entry for change in StackStorm/st2#4217.