-
-
Notifications
You must be signed in to change notification settings - Fork 775
Bump dnspython to 2.6.1 to fix pack CI failure on py3.10/py3.11 #6265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
30b4c58 to
e1d5990
Compare
|
What if we just removed dnspython from our requirements files and let pip pick the version? Or, what if we just removed the constraint from |
|
To clarify: the original reason for pinning |
e1d5990 to
14079d1
Compare
|
Dropped pinning for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the lockfile was regenerated with these requirements changes (which includes transitive deps). Normally regenerating the lockfile displays a summary of these changes--I like to copy that into a comment on the PR.
arcomplete3.5.0->3.5.1charset-normalizer3.3.2->3.4.0cryptography43.0.1->43.0.3distlib0.3.8->0.3.9dnspython1.16.0->2.6.1greenlet3.1.0->3.1.1prompt-toolkit3.0.47->3.0.48psutil6.0.0->6.1.0redis5.0.8->5.1.1setuptools75.1.0->75.2.0tomli2.0.1->2.0.2tzdata2024.1->2024.2virtualenv20.26.5->20.27.0xmltodict0.13.0->0.14.2
Would you please update these in fixed-requirements.txt to match the lockfile?
argcompletecryptographygreenletprompt-toolkitpsutilredisvirtualenv
And please update this in the Makefile:
setuptools
Aside: eventually, pants should gain the ability to update only some of the deps instead of regenerating the whole thing. Sorry for the mess in the interim.
If you'd prefer, we can submit these extra fixed-requirements.txt changes in a follow-up PR. Because everything else LGTM. I'm approving this for now, assuming these updates are made in such a follow-up.
Update
dnspythonto v2.6.1 to fix pack CI failing for py3.10 / py3.11 withAttributeError: module 'collections' has no attribute 'MutableMapping'.